| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Marko Kreen <markokr(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Kurt Harriman <harriman(at)acm(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Patch: Remove gcc dependency in definition of inline functions |
| Date: | 2009-12-16 19:36:47 |
| Message-ID: | 1260992207.15029.0.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On ons, 2009-12-16 at 10:49 -0500, Tom Lane wrote:
> Marko Kreen <markokr(at)gmail(dot)com> writes:
> > So the plain-C89 compilers would be downgraded to "second-class"
> > targets, not worth getting max performance out of them.
>
> Hm? Failing to inline is already a performance hit, which is why
> Kurt got interested in this in the first place.
>
> I think you're way overthinking this. Where we started was just
> a proposal to try to expand the set of inline-ing compilers beyond
> "gcc only". I don't see why we need to do anything but that. The
> code is fine as-is except for the control #ifdefs.
I think the ifdefs should just be HAVE_INLINE && !MSVC, right?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2009-12-16 19:39:14 | Re: PATCH: Spurious "22" in hstore.sgml |
| Previous Message | David E. Wheeler | 2009-12-16 19:34:33 | PATCH: Spurious "22" in hstore.sgml |