From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: split rm_name and rm_desc out of rmgr.c |
Date: | 2013-02-05 23:38:42 |
Message-ID: | 12600.1360107522@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Patch attached.
Seems like a couple of the comments could use updates:
> * Note: RM_MAX_ID could be as much as 255 without breaking the XLOG file
> * format, but we keep it small to minimize the size of RmgrTable[].
This is no longer particularly sensible, since we're no longer making
any provision for wasted RmgrIds. Perhaps rephrase as "RM_MAX_ID must
fit in RmgrId; widening that type will affect the XLOG file format."
> + * List of resource manager entries. Note that order of entries defines the
> + * numerical values of each rmgr's ID.
> + *
> + * Changes to this list possibly need a XLOG_PAGE_MAGIC bump.
Probably also a good idea to state explicitly that new entries should go
at the end to avoid moving the IDs of existing entries.
Works for me otherwise.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2013-02-05 23:58:02 | Re: sql_drop Event Trigger |
Previous Message | Tom Lane | 2013-02-05 23:09:36 | Re: issues with range types, btree_gist and constraints |