Re: unknown libpq service entries ignored

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: unknown libpq service entries ignored
Date: 2009-11-27 22:16:09
Message-ID: 1259360169.4396.27.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On fre, 2009-11-27 at 10:22 -0500, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > + printfPQExpBuffer(errorMessage,
> > + libpq_gettext("ERROR: service \"%s\" not found\n"), service);
>
> Please make the message consistent with the rest of libpq. AFAICS none
> of the other messages in that file use an ERROR: prefix.

Well, that style is used four times in that same function, but no where
else in the file. So the existing uses should probably also be cleaned
up.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-11-27 23:04:58 Re: Re: [COMMITTERS] pgsql: Rewrite GEQO's gimme_tree function so that it always finds a
Previous Message Tom Lane 2009-11-27 21:58:31 Re: OpenSSL key renegotiation with patched openssl