| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Daniel Farina <drfarina(at)gmail(dot)com>, Hannu Krosing <hannu(at)krosing(dot)net>, Greg Smith <greg(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Daniel Farina <dfarina(at)truviso(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION |
| Date: | 2009-11-25 04:16:20 |
| Message-ID: | 1259122580.19289.6.camel@jdavis |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 2009-11-24 at 14:39 +0100, Pavel Stehule wrote:
> a) good designed C API like:
>
> initialise_functions(fcinfo) -- std fcinfo
> consument_process_tuple(fcinfo) -- gets standard row -- Datum
> dvalues[] + Row description
> producent_process_tuple(fcinfo) -- returns standard row -- Datum
> dvalues[] + Row description (look on SRF API)
> terminate_funnction(fcinfo)
>
Don't you still need the functions to accept an argument of type
internal? Otherwise, we lose the ability to copy a buffer to the dblink
connection, which was the original motivation.
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Izmailov | 2009-11-25 04:29:16 | Re: pg_attribute.attnum - wrong column ordinal? |
| Previous Message | KaiGai Kohei | 2009-11-25 04:07:34 | Re: SE-PgSQL patch review |