Re: byteain for new hex escaped data

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Kris Jurka <books(at)ejurka(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: byteain for new hex escaped data
Date: 2009-11-18 13:30:30
Message-ID: 1258551030.3497.32.camel@fsopti579.F-Secure.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On ons, 2009-11-18 at 06:46 -0500, Kris Jurka wrote:
> Looking at how byteain detects whether the input it is passed is the new
> hex format escape or the old octal escape, it uses:
>
> char *inputText = PG_GETARG_CSTRING(0);
> if (inputText[0] == '\\' && inputText[1] == 'x')
>
> Doesn't this read off the end of inputText in the case of "SELECT
> ''::bytea", or is there some padding happening somewhere that makes this
> legal?

In case of ''::bytea, the inputText is "" as a C string, and so
inputText[0] == '\0' and the second test is not executed.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2009-11-18 13:31:24 Re: RFC for adding typmods to functions
Previous Message Heikki Linnakangas 2009-11-18 12:51:35 Re: Summary and Plan for Hot Standby