| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> |
| Cc: | Daisuke Higuchi <higuchi(dot)daisuke11(at)gmail(dot)com>, pgsql-docs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: doc: Fix the header file where CompareType is defined in gist.sgml |
| Date: | 2025-12-16 08:50:22 |
| Message-ID: | 1256D2D9-8300-4526-9F85-ECB8CA769E59@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
> On 16 Dec 2025, at 00:19, Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> wrote:
>
> On Sat, Dec 13, 2025 at 12:25 AM Daisuke Higuchi
> <higuchi(dot)daisuke11(at)gmail(dot)com> wrote:
>>
>> I found that the header file where CompareType was actually defined did not match the header file described in gist.sgml.
>> CompareType is currently defined at "src/include/access/cmptype.h" instead of "src/include/nodes/primnodes.h".
>> This change was made in the commit below, but it seems that documentation update was missed.
>>
>> https://github.com/postgres/postgres/commit/119fc30dd5bd918819b864107ddc8baac51f4d22
>
> You're right, that's where we define it. Your email landed in Gmail's
> spam folder for me, so hopefully this +1 will help it not be missed by
> a committer.
Thanks for the report, fixing it right now.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Doc comments form | 2025-12-17 00:45:14 | missing documentation detail? |
| Previous Message | Paul A Jungwirth | 2025-12-15 23:19:34 | Re: doc: Fix the header file where CompareType is defined in gist.sgml |