Skip site navigation (1) Skip section navigation (2)

Re: Parsing config files in a directory

From: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Thom Brown <thombrown(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Greg Smith <gsmith(at)gregsmith(dot)com>, Greg Stark <gsstark(at)mit(dot)edu>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Parsing config files in a directory
Date: 2009-10-29 16:13:52
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
On Thu, 2009-10-29 at 11:42 -0400, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > The whole config file is a joke. We'd never do it the way we do if we 
> > were designing it from scratch,
> Why not, pray tell?  We did design it from scratch, once upon a time,
> and I don't see that the design is so obviously broken that we'd not
> do the same thing if starting over.

Because, there is no right answer. There is not a defined standard to
attach to. The requirements all over the place and in this case there
are a large number of contributors that actually have an opinion (unlike
say the Hot Standby implementation).

> > but we seem to be incapable of biting 
> > the bullet and replacing it with something sane, which is why I have 
> > ignored most of the current debate.
> I guess we'll just go without the benefit of your superior intelligence
> then.

I think the point is, this discussion has happened many times. People
get kind of tired of burning cycles on the same thing over and over.

I personally don't have any problem with the existing postgresql.conf
except for the following:

1. I should be able to edit it from PostgreSQL via a query (assuming
super user privs or some such thing)

In fact I would be perfectly happy to NEVER open an editor again to edit
the postgresql.conf and just have a revision system in conjunction with
a SET LOCAL|GLOBAL command. Where local would be for the session and
GLOBAL would be permanent.

Then again, I don't really care that I have to open an editor either. I
also understand that a SET LOCAL|GLOBAL is likely to wreak havoc on an
include implementation. Of course a SET LOCAL|GLOBAL implementation
eliminates the need for an include implementation. Queue up the
pitchforks now.

2. The file contains a bunch of information that shouldn't be there. We
should have the bare minimum required for PostgreSQL to start. 

As far as this on-going postgres vs postgresql debate. There are some
already pretty well defined industry (if not specific body) standards
for configuration files.

The ones I run into the most are:

XML : Pretty much anything written in Java is going to use this 

Config : This is what you see in a lot of Perl or Python installs where
you have something like this:

listen_addresses = 

checkpoint_segments = 


In regards to parsing files in a directory. It makes sense. Why the
implementation is so difficult is beyond me. Can't we just look at
Apache and say, "Gee, it may not be perfect but it does everything we
need, let's use their implementation."?


Joshua D. Drake

-- Major Contributor
Command Prompt, Inc: - 503.667.4564
Consulting, Training, Support, Custom Development, Engineering
If the world pushes look it in the eye and GRR. Then push back harder. - Salamander

In response to


pgsql-hackers by date

Next:From: Andrew DunstanDate: 2009-10-29 16:18:28
Subject: Re: Parsing config files in a directory
Previous:From: Stephen FrostDate: 2009-10-29 15:55:40
Subject: Re: Show schema size with \dn+

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group