| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Radix tree for character conversion |
| Date: | 2016-10-07 16:19:23 |
| Message-ID: | 12566.1475857163@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Fri, Oct 7, 2016 at 6:46 AM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>> Ouch. We should find and document an authoritative source for all the
>> mappings we have...
>>
>> I think the next steps here are:
>>
>> 1. Find an authoritative source for all the existing mappings.
>> 2. Generate the radix tree files directly from the authoritative sources,
>> instead of the existing *.map files.
>> 3. Completely replace the existing binary-search code with this.
> It might be best to convert using the existing map files, and then
> update the mappings later. Otherwise, when things break, you won't
> know what to blame.
I think I went through this exercise last year or so, and updated the
notes about the authoritative sources where I was able to find one.
In the remaining cases, I believe that the maps have been intentionally
tweaked and we should be cautious about undoing that. Tatsuo-san might
remember more about why they are the way they are.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gilles Darold | 2016-10-07 16:25:38 | Re: Patch to implement pg_current_logfile() function |
| Previous Message | Tom Lane | 2016-10-07 16:06:17 | Re: Is it time to kill support for very old servers? |