| From: | "Andrew Dunstan" <andrew(at)dunslane(dot)net> |
|---|---|
| To: | <neilc(at)samurai(dot)com> |
| Cc: | <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: cleanup error reporting |
| Date: | 2006-03-01 13:23:17 |
| Message-ID: | 1255.24.211.165.134.1141219397.squirrel@www.dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Neil Conway said:
> On Tue, 2006-02-28 at 22:38 -0500, Tom Lane wrote:
>> There are one or two "cannot"s that should be "could not"s in your hit
>> list, per the style guidelines.
>>
>> While you're at it -- I noticed several of the tsearch2 messages refer
>> to "lexem(s)". The word is "lexeme", the plural "lexemes", so this
>> should be "lexeme(s)". Looks like it's misspelled various places in
>> the README and code comments too ...
>
> Thanks for the suggestions -- I fixed both of those issues, and applied
> a revised patch to HEAD.
>
This has apparently broken regression tests in both contrib and PL. See
buildfarm for details.
(side note - maybe we need a check target for these that uses a temp install
- that would make it easier to check for errors like this).
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-03-01 16:08:05 | Re: cleanup error reporting |
| Previous Message | Neil Conway | 2006-03-01 06:56:43 | Re: cleanup StringInfo usage |