Re: Logging configuration changes [REVIEW]

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Abhijit Menon-Sen <ams(at)toroid(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Logging configuration changes [REVIEW]
Date: 2009-09-17 21:39:28
Message-ID: 1253223568.21712.16.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On ons, 2009-09-16 at 10:54 +0530, Abhijit Menon-Sen wrote:
> I can't help but think that it would be nice to report the default value
> of a parameter that is reset (i.e. "parameter $x reset to default value
> $y"). The first attached patch does this by calling GetConfigOption()
> after the value has been reset by set_config_option(). It also skips
> the report if the earlier value was the same as the default.

I have applied the rest, but the problem with this change is that it
logs the values without units. I'm not sure that we want to expose
that.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-09-17 21:41:01 Re: Feedback on getting rid of VACUUM FULL
Previous Message Andrew Dunstan 2009-09-17 21:29:46 Re: Fwd: Copy out wording