Re: compilation with libeditpreferred is broken

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: compilation with libeditpreferred is broken
Date: 2009-08-12 19:59:31
Message-ID: 1250107171.1240.11.camel@localhost
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I attached conservative version of patch which only reorder #define to
avoid cross including half from readline and half from editline.

Zdenek

Tom Lane píše v čt 06. 08. 2009 v 18:13 -0400:
> Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
> > It seems to me that editline never distributed history.h file and
> > HAVE_EDITLINE_HISTORY_H is nonsense. But I'm not sure.
>
> I wouldn't count on that, in part because there are so many versions of
> editline. On an OS X machine I see
>
> $ ls -l /usr/include/*line*
> /usr/include/editline:
> total 16
> -rw-r--r-- 1 root wheel 6882 Feb 19 2008 readline.h
>
> /usr/include/readline:
> total 16
> lrwxr-xr-x 1 root wheel 22 Jul 23 11:31 history.h@ -> ../editline/readline.h
> lrwxr-xr-x 1 root wheel 22 Jul 23 11:31 readline.h@ -> ../editline/readline.h
>
> regards, tom lane

Attachment Content-Type Size
libedit_v02.patch text/x-patch 825 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2009-08-12 20:48:24 Re: WIP: getting rid of the pg_database flat file
Previous Message Tom Lane 2009-08-12 18:21:49 Re: WIP: getting rid of the pg_database flat file