Re: Prefix support for synonym dictionary

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Prefix support for synonym dictionary
Date: 2009-08-02 19:05:24
Message-ID: 1249239924.4765.6926.camel@jdavis
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


The patch looks good.


1. The docs should be clarified a little. For instance, it should have a
link back to the definition of a prefix search (12.3.2). I included my
doc suggestions as an attachment.

2. dsynonym_init() uses findwrd() in a slightly confusing (and perhaps
fragile) way. After calling findwrd(), the "end" pointer is pointing at
either the end of the string, or the *; depending on whether the string
ends in * and whether flags is NULL. I only mention this because I had
to take a more careful look to see what was happening. Perhaps add a
comment to make it more clear?

3. The patch looks for the special byte '*'. I think that's fine,
because we depend on the files being in UTF-8 encoding, where it's the
same byte. However, I thought it was worth mentioning in case we want to
support other encodings for text search files later.

Jeff Davis

Attachment Content-Type Size
prefix-synonym-review.diff text/x-patch 2.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2009-08-02 19:19:15 compiler warning
Previous Message Pavel Stehule 2009-08-02 17:55:08 Re: ALTER TABLE ... ALTER COLUMN ... SET DISTINCT