Re: Patch for unreleased memory in buf_init.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Ulrich Neumann" <U_Neumann(at)gne(dot)de>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Patch for unreleased memory in buf_init.c
Date: 2002-08-12 16:15:13
Message-ID: 12473.1029168913@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

I said:
> Hmm, so the point is to reclaim memory during a shmem reinit cycle?

But on third think, it doesn't do that either, and in fact is just a
waste of cycles. ShutdownBufferPoolAccess is only called in a backend
that is about to exit, and the storage you propose it should release
is local to that backend ...

So the patch appears harmless but also useless. A backend on-exit
routine is generally only interested in cleaning up state that is
visible to other backends --- I can't see any point in expending cycles
to tidy up local memory that's about to vanish.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Ulrich Neumann 2002-08-12 16:16:18 Antw: Re: Patch for unreleased memory in buf_init.c
Previous Message Ulrich Neumann 2002-08-12 16:06:48 Antw: Re: Patch for NetWare support