Re: Disabling src/test/[ssl|ldap] when not building with SSL/LDAP support

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Disabling src/test/[ssl|ldap] when not building with SSL/LDAP support
Date: 2018-02-08 14:28:10
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> In order to run tests consistently on the whole tree, I use a simple
> alias which tests also things like src/test/ssl and src/test/ldap on the
> way.

> Lately, I am getting annoyed by $subject when working on OpenSSL stuff
> as sometimes I need to test things with and without SSL support to make
> sure that a patch is rightly shaped. However if configure is built
> without SSL support then src/test/ssl just fails. The same applies to
> src/test/ldap.

> Could it be possible to disable them using something like the attached
> if a build is done without SSL and/or LDAP?

That seems like possibly not such a great idea. If somebody were using
a run of src/test/ssl to check their build, they would now get no
notification if they'd forgotten to build --with-openssl.

Perhaps we could introduce some new targets, "check-if-enabled" or so,
that act like you want.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Claudio Freire 2018-02-08 15:45:15 Re: [HACKERS] [PATCH] Vacuum: Update FSM more frequently
Previous Message Andres Freund 2018-02-08 14:24:06 Re: JIT compiling with LLVM v10.0