From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Resolving pg_standby -l |
Date: | 2009-06-25 15:14:14 |
Message-ID: | 1245942854.4038.115.camel@ebony.2ndQuadrant |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, 2009-06-25 at 09:51 -0400, Tom Lane wrote:
> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> > --- 610,621 ----
> > }
> > break;
> > case 'l': /* Use link */
> > ! /*
> > ! * Link feature disabled, possibly permanently. Linking
> > ! * causes a problem after recovery ends that is not currently
> > ! * resolved by PostgreSQL. 25 Jun 2009
> > ! restoreCommandType = RESTORE_COMMAND_LINK;
> > ! */
> > break;
> > case 'r': /* Retries */
> > maxretries = atoi(optarg);
>
> Just for future reference: the above is going to look like hell after
> pgindent gets its hands on it. Better style for this project is
>
> /*
> * ordinary comment block
> */
> #ifdef NOT_USED
> code to be disabled
> #endif
Will do, thanks. Patch to cleanup as advised is attached.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
Attachment | Content-Type | Size |
---|---|---|
pg_standby_code_clean.patch | text/x-patch | 1.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Meskes | 2009-06-25 15:18:05 | Re: ECPG dynamic cursor, SQLDA support |
Previous Message | Tom Lane | 2009-06-25 14:16:18 | Re: Extensions User Design |