Re: DTrace probe patch for OS X Leopard

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Lor <Robert(dot)Lor(at)Sun(dot)COM>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: DTrace probe patch for OS X Leopard
Date: 2008-02-29 20:40:13
Message-ID: 12440.1204317613@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Robert Lor <Robert(dot)Lor(at)Sun(dot)COM> writes:
> And don't think adding a simple comment before the macro call is
> sufficient? This can be documented so everyone knows the convention.

It's stupid. The need for a comment is proof that the macro is badly
named. I don't intend to hold still for letting poorly-designed tools
dictate our coding conventions.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2008-02-29 20:49:48 Re: DTrace probe patch for OS X Leopard
Previous Message Zdenek Kotala 2008-02-29 20:39:58 Remove FATAL from pg_lzdecompress