| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Greg Stark <stark(at)mit(dot)edu> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] Re: pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after |
| Date: | 2010-02-28 19:31:00 |
| Message-ID: | 12428.1267385460@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Greg Stark <stark(at)mit(dot)edu> writes:
> So I'm thinking of something like this.
> Ignore ESDIR when opening a directory (and return immediately)
> and ignore EBADF when trying to fsync a directory.
Seems reasonable, but get rid of the comment "However we can't do this
just yet, it has portability issues"; and you've got a double semicolon
in one place. It might also be worth commenting the BasicOpenFile calls
along the lines of "Many OSs don't let us open directories RDWR, while
some reject fsync on files opened RDONLY, so we need two cases."
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-02-28 19:51:37 | pgsql: Assorted code cleanup for contrib/xml2. |
| Previous Message | Greg Stark | 2010-02-28 18:00:07 | Re: [COMMITTERS] Re: pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2010-02-28 19:47:38 | Re: Re: Hot Standby query cancellation and Streaming Replication integration |
| Previous Message | Tom Lane | 2010-02-28 19:25:57 | Simple fix for contrib/xml2 |