Re: pgsql: Remove inappropriate memory context switch in

"Neil Conway" <neilc(at)samurai(dot)com> writes:
> On Sun, Nov 30, 2008 at 1:09 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Well, dblink is simply calling SRF_RETURN_DONE() when the current
> context is the multi-call memory context.

So I see.

> We could outlaw that
> practice, but that risks breaking out-of-tree SRFs that do something
> similar.

No, they're already broken; this is just making the breakage more
obvious. It is not kosher for a SQL-callable function to return with
a different current context than it was called in.

regards, tom lane