Re: subplan resets wrong hashtable

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: subplan resets wrong hashtable
Date: 2020-02-29 19:05:51
Message-ID: 12420.1583003151@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> Right. So the incorrect ResetTupleHashTable call is unreachable
> (and a look at the code coverage report confirms that). The whole
> thing obviously is a bit hasty and unreviewed, but it doesn't have
> a live bug AFAICS ... or at least, if there's a bug, it's a memory
> leakage issue across repeat executions, not a crash hazard.

For the archives' sake: this *is* a memory leak, and we dealt with
it at 58c47ccfff20b8c125903482725c1dbfd30beade.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chris Bandy 2020-02-29 19:33:48 [PATCH] Add schema and table names to partition error
Previous Message Tom Lane 2020-02-29 19:02:59 Re: Broken resetting of subplan hash tables