Re: WIP patch for TODO Item: Add prompt escape to display the client and server versions

From: "Dickson S(dot) Guedes" <listas(at)guedesoft(dot)net>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: WIP patch for TODO Item: Add prompt escape to display the client and server versions
Date: 2009-05-07 12:09:39
Message-ID: 1241698179.25272.16.camel@analise3.cresoltec.com.br
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em Qui, 2009-05-07 às 10:11 +0300, Peter Eisentraut escreveu:
> On Thursday 07 May 2009 05:23:41 Dickson S. Guedes wrote:
> > This is a WIP patch (for the TODO item in the subject) that I'm putting
> > in the Commit Fest queue for 8.5.
>
> How about you just put the values in a variable and use the existing facility
> to put those variables in the prompt?

Change all "pset.version calculations" in "case 'V'" to something like
"case 'v'" is doing with PG_VERSION? Yes, could be better.

The specific code used to %V and %v in this patch was "inspired" in the
code in connection_warnings function in commands.c, so should this be
"refactored" too?

Thanks.

Dickson S. Guedes
mail/xmpp: guedes(at)guedesoft(dot)net - skype: guediz
http://guedesoft.net - http://planeta.postgresql.org.br

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2009-05-07 12:26:31 Re: Serializable Isolation without blocking
Previous Message Simon Riggs 2009-05-07 12:01:16 Re: Serializable Isolation without blocking