Re: Patch to fix search_path defencies with pg_bench

From: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
To: "Dickson S(dot) Guedes" <listas(at)guedesoft(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Greg Smith <gsmith(at)gregsmith(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Patch to fix search_path defencies with pg_bench
Date: 2009-05-06 20:49:10
Message-ID: 1241642950.4278.112.camel@jd-laptop.pragmaticzealot.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 2009-05-06 at 17:42 -0300, Dickson S. Guedes wrote:
> Em Qua, 2009-05-06 às 16:27 -0400, Tom Lane escreveu:
> > Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > > I think it would be better that the schema is specified on the command
> > > line.
> >
> > Surely that's more work than the issue is worth. It's also inconvenient
> > to use, because you'd have to remember to give the switch both for the
> > -i run and the normal test runs.
>
> So, in my opinion, the Joshua alternative is a good little change that
> let "pgbench" runs in a more flexible way.
>
> But, there is the possibility that someone are using an automated script
> that could be broken by this change?

Only if the role pgbench is using as an explicit search_path set.

Sincerely,

Joshua D. Drake

--
PostgreSQL - XMPP: jdrake(at)jabber(dot)postgresql(dot)org
Consulting, Development, Support, Training
503-667-4564 - http://www.commandprompt.com/
The PostgreSQL Company, serving since 1997

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-05-06 20:58:35 Re: text_pattern_ops and complex regexps
Previous Message Andrew Dunstan 2009-05-06 20:47:45 Re: text_pattern_ops and complex regexps