| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andreas Karlsson <andreas(at)proxel(dot)se>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, David Fetter <david(at)fetter(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Early WIP/PoC for inlining CTEs |
| Date: | 2019-01-28 20:35:32 |
| Message-ID: | 12408.1548707732@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> However, generally we have not had great luck with just sticking
> keywords in there (cf. VACUUM, ANALYZE, EXPLAIN, COPY) which is why I
> suggested using a flexible syntax with parenthesized options.
Fair, except that as you then proceed to point out, that does not work
either before or after the AS.
Conceivably we could make it work without the parens:
WITH ctename AS [ option = value [ , .... ] ] ( query .... )
which for the immediate feature I'd be tempted to spell as
WITH ctename AS [ materialize = on/off ] ( query ... )
I think the only reason the syntax is MATERIALIZED with a D is that
that's already a keyword; it reads a bit awkwardly IMO. But if we
were accepting a ColId there, there'd be room to adjust the spelling.
That said, this is still clunkier than the existing proposal, and
I'm not really convinced that we need to leave room for more options.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nishant, Fnu | 2019-01-28 20:47:04 | Re: possible deadlock: different lock ordering for heap pages |
| Previous Message | Robert Haas | 2019-01-28 20:33:10 | Re: Proposed refactoring of planner header files |