citex regression fails with de.UTF8 locale

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: citex regression fails with de.UTF8 locale
Date: 2009-04-23 06:27:54
Message-ID: 1240468074.1275.7.camel@localhost
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I setup more locale testing on gothic moth and citext regression test
fails.

See
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-04-22%2020:06:01

Problem is here:

---------------------------------------------------
SELECT citext_cmp('B'::citext, 'a'::citext) AS one;
one
-----
! 1
(1 row)

-- Do some tests using a table and index.
--- 216,222 ----
SELECT citext_cmp('B'::citext, 'a'::citext) AS one;
one
-----
! 28
(1 row)

-- Do some tests using a table and index.
---------------------------------------------------

It seems to me that citex_cmp can return any integer value. It depends
what wcscoll() returns. I think it should be changed to:

SELECT citext_cmp('B'::citext, 'a'::citext) > 0 AS one;

Zdenek

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2009-04-23 07:22:12 Re: citex regression fails with de.UTF8 locale
Previous Message Fujii Masao 2009-04-23 04:09:30 Re: The last WAL segment of the old timeline is not archived for a while after archive recovery