Re: extensible options syntax for replication parser?

From: Sergei Kornilov <sk(at)zsrv(dot)org>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: extensible options syntax for replication parser?
Date: 2021-09-22 12:11:10
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


Thanks, I missed this thread.

> + <term><literal>CHECKPOINT { 'fast' | 'spread' }</replaceable></literal></term>

Unpaired </replaceable> tag in docs.

That was all I noticed in 0001. Still not sure where is the difference between "change NOWAIT to WAIT" and "change NOWAIT to something else descriptive". But fine, I can live with WAIT. (one note: the exact command is visible to the user when log_replication_commands is enabled, not completely hidden)

0002 breaks "create subscription (with create_slot true)" when the publish server is an earlier version:

postgres=# create subscription test CONNECTION 'host= user=postgres' PUBLICATION test with (create_slot = true);
ERROR: could not create replication slot "test": ERROR: syntax error

regards, Sergei

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amul Sul 2021-09-22 12:48:30 Re: [Patch] ALTER SYSTEM READ ONLY
Previous Message Marcos Pegoraro 2021-09-22 11:56:09 Re: logical replication restrictions