Re: CI: Add task that runs pgindent

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Jelte Fennema-Nio <me(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Subject: Re: CI: Add task that runs pgindent
Date: 2025-11-07 16:07:35
Message-ID: 1233967.1762531655@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> Why does this need to be a separate task, instead of being folded into the
> CompilerWarnings task or such? Increasing the peak numbers of CPUs cfbot needs
> is unfortunately somewhat annoying, as I've been fighting w/ GCP to increase
> the quotas much higher than what they are right now.

We had that discussion upthread, or maybe it was on Discord: we want
to keep formatting complaints separate from actual compiler warnings.
The latter should be fixed before the patch can be considered ready,
whereas pgindent might get left for the committer to do. An example
where that's actually good practice is where the patch has to reindent
a chunk of existing code; submitting it without that makes review
simpler.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Jones 2025-11-07 16:16:38 Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement
Previous Message Andrei Lepikhov 2025-11-07 16:05:55 Re: Sequence Access Methods, round two