| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, phb(dot)emaj(at)free(dot)fr, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18923: pg_dump 18beta1 fails to process complex table names |
| Date: | 2025-05-15 19:03:21 |
| Message-ID: | 12329.1747335801@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> I don't think we want to teach appendPGArray() to handle single quotes.
No, that seems quite wrong. array_in won't de-dup single quotes.
> My first instinct is that we need to build the array with appendPGArray()
> and then append it to the query using appendStringLiteralAH(), as done in
> the attached patch.
Yeah, I think so. I was confused for a bit because the one extant
user of appendPGArray is getNamespaces which does an additional layer
of quote-doubling via quoteAclUserName. However, that seems to be because
it's trying to build aclitem[] arrays whose elements will be read by
aclitemin, and that de-dups double quotes.
Wouldn't be a bad idea to add a test case.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2025-05-16 06:15:48 | Re: Re: BUG #18927: Poor query plan - HashAggregate is more than twice as fast but at a higher cost |
| Previous Message | Corey Huinker | 2025-05-15 19:03:11 | Re: BUG #18923: pg_dump 18beta1 fails to process complex table names |