Re: [PATCHES] updated hash functions for postgresql v1

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Kenneth Marshall <ktm(at)rice(dot)edu>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCHES] updated hash functions for postgresql v1
Date: 2009-01-10 18:56:15
Message-ID: 1231613775.25019.110.camel@jdavis
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, 2009-01-10 at 13:36 -0500, Tom Lane wrote:
> Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> > I ran 5 times on both old and new code, eliminating the top and bottom
> > and taking the average of the remaining 3, and I got a 6.9% performance
> > improvement with the new code.
>
> The question that has been carefully evaded throughout the discussion
> of this patch is whether the randomness of the hash result is decreased,
> and if so what is that likely to cost us in performance of the various
> hash-dependent algorithms. I would still like to have an answer to that
> before we make a change to gain marginal performance improvement in
> the hash function itself (which is already shown to be barely measurable
> in the total context of a hash-dependent operation...)
>

In:
http://archives.postgresql.org/message-id/20081104202655.GP18362@it.is.rice.edu

Ken showed that the number of hash collisions is the same in the old and
the new code for his test data. Not a direct measurement of randomness,
but it's some kind of indication.

I'm not an authority on either hash functions or statistics, so I'll
have to defer to Ken or someone else to actually prove that the
randomness is maintained.

Regards,
Jeff Davis

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gregory Stark 2009-01-10 18:57:27 Re: [PATCHES] updated hash functions for postgresql v1
Previous Message Tom Lane 2009-01-10 18:51:05 Re: [SPAM] Re: posix_fadvise v22