| From: | Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH][PROPOSAL] Add enum releation option type |
| Date: | 2018-03-07 15:23:03 |
| Message-ID: | 12291633.PFnvXaAOpE@x200m |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
В письме от 1 марта 2018 14:47:35 пользователь Alvaro Herrera написал:
> I see you lost the Oxford comma:
>
> -DETAIL: Valid values are "on", "off", and "auto".
> +DETAIL: Valid values are "auto", "on" and "off".
>
> Please put these back.
Actually that's me who have lost it. The code with oxford comma would be a
bit more complicated. We should put such coma when we have 3+ items and do not
put it when we have 2.
Does it worth it?
As I've read oxford using of comma is not mandatory and used to avoid
ambiguity.
"XXX, YYY and ZZZ" can be read as "XXX, YYY, ZZZ" or as "XXX, (YYY and ZZZ)".
oxford comma is used to make sure that YYY and ZZZ are separate items of the
list, not an expression inside one item.
But here we hardly have such ambiguity.
So I'll ask again, do you really think it worth it?
--
Do code for fun.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2018-03-07 15:26:31 | Re: public schema default ACL |
| Previous Message | Petr Jelinek | 2018-03-07 15:22:23 | Re: public schema default ACL |