| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(at)postgresql(dot)org> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Unite ReadBufferWithFork, ReadBufferWithStrategy, and |
| Date: | 2008-10-31 20:37:40 |
| Message-ID: | 1225485460.3971.618.camel@ebony.2ndQuadrant |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, 2008-10-31 at 15:05 +0000, Heikki Linnakangas wrote:
> Log Message:
> -----------
> Unite ReadBufferWithFork, ReadBufferWithStrategy, and ZeroOrReadBuffer
> functions into one ReadBufferExtended function, that takes the strategy
> and mode as argument. There's three modes, RBM_NORMAL which is the default
> used by plain ReadBuffer(), RBM_ZERO, which replaces ZeroOrReadBuffer, and
> a new mode RBM_ZERO_ON_ERROR, which allows callers to read corrupt pages
> without throwing an error. The FSM needs the new mode to recover from
> corrupt pages, which could happend if we crash after extending an FSM file,
> and the new page is "torn".
I thought you were adding the "read buffer only if in cache" option
also?
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-10-31 21:07:55 | pgsql: Simplify ExecutorRun's API and save some trivial number of cycles |
| Previous Message | Heikki Linnakangas | 2008-10-31 19:40:27 | pgsql: Update FSM on WAL replay. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aidan Van Dyk | 2008-10-31 21:02:11 | Re: Decreasing WAL size effects |
| Previous Message | Tom Lane | 2008-10-31 19:37:56 | pgsql: Allow SQL-language functions to return the output of an |