From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: allow online change primary_conninfo |
Date: | 2018-11-26 18:21:41 |
Message-ID: | 122481543256501@sas1-ea1d14049a51.qloud-c.yandex.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi
>> Hmm... I considered SIGHUP processing was in fast loop and therefore shutdown should be fast. But i recheck code and found a possible long loop without processing SIGHUP (in case we receive new data faster than writes to disk). Ok, i will revert back.
>> How about write to WalRcvData only clobbered conninfo?
>
> I'm not sure I understand what you mean?
I am about my initial proposal with remove conninfo wrom WalRcvData - walreceiver may run some time with old conninfo and
> without this information that seems hard to debug.
Earlier i thought walreceiver will shutdown fast on SIGHUP.
> The way I'd solve this is that
> that only walreceiver, at startup, writes out its conninfo/slot_name,
> sourcing the values from the GUCs. That way there's no issue with values
> being overwritten early.
In second patch i follow exactly this logic.
regards, Sergei
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2018-11-26 18:30:18 | Re: pgsql: Integrate recovery.conf into postgresql.conf |
Previous Message | Andres Freund | 2018-11-26 18:15:06 | Re: pgsql: Integrate recovery.conf into postgresql.conf |