Re: [COMMITTERS] pgsql: Rework subtransaction commit protocol for hot standby.

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [COMMITTERS] pgsql: Rework subtransaction commit protocol for hot standby.
Date: 2008-10-23 03:31:49
Message-ID: 1224732709.27145.553.camel@ebony.2ndQuadrant
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


On Wed, 2008-10-22 at 13:25 -0400, Tom Lane wrote:

> I can't reproduce this 100% reliably, but the case where I saw it came
> from mistakenly inserting
> Assert(!IsA(node, AppendRelInfo));
> into flatten_join_alias_vars_mutator and then running the serial
> regression tests. This case *can* happen, but it doesn't occur
> until late in the regression tests. The recovery ensuing from the
> assert failure crashes maybe one time in two --- likely has something
> to do with when the last checkpoint happened.

This seems like a useful type of test.

Can we change regression tests so that we avoid checkpoints, then crash
at the end of the test and go through recovery process? That would be a
neat way of including a recovery check in with each make check.

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2008-10-23 03:38:20 Re: Re: [COMMITTERS] pgsql: Rework subtransaction commit protocol for hot standby.
Previous Message Tom Lane 2008-10-23 00:24:51 pgsql: When estimating without benefit of MCV lists (suggesting that one

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2008-10-23 03:38:20 Re: Re: [COMMITTERS] pgsql: Rework subtransaction commit protocol for hot standby.
Previous Message Charles Duffy 2008-10-23 03:10:55 Making pg_standby compression-friendly