| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Zeugswetter Andreas OSB sIT <Andreas(dot)Zeugswetter(at)s-itsolutions(dot)at> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "pgadmin-hackers(at)postgresql(dot)org" <pgadmin-hackers(at)postgresql(dot)org>, "pgsql-general(at)postgresql(dot)org" <pgsql-general(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Hot Standby utility and administrator functions |
| Date: | 2008-10-21 14:15:12 |
| Message-ID: | 1224598512.27145.94.camel@ebony.2ndQuadrant |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers pgsql-general pgsql-hackers |
On Tue, 2008-10-21 at 09:44 +0200, Zeugswetter Andreas OSB sIT wrote:
> > > * pg_last_recovered_xact_xid()
> > > Will throw an ERROR if *not* executed in recovery mode.
> > > returns bigint
> > >
> > > * pg_last_completed_xact_xid()
> > > Will throw an ERROR *if* executed in recovery mode.
> > > returns bigint
> >
> > Should these return xid?
>
> And shouldn't these two be folded together ?
> It seems most usages of this xid(/lsn?) will be agnostic to the
> recovery mode. Or if not, it seems more convenient to have a function
> that returns both recovery mode and xid, no ?
You are right that it would be better to have a single function.
Functions that return multiple values are a pain to use and develop,
plus we can always run the other function if we are in doubt.
txid_last_completed() returns bigint (txid) seems better.
I am more than happy to add an id version as well, if anybody sees the
need for that. Just say.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gevik Babakhani | 2008-10-22 08:15:01 | website down? |
| Previous Message | Tom Lane | 2008-10-21 12:10:00 | Re: [HACKERS] Hot Standby utility and administrator functions |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2008-10-21 14:21:34 | Re: Where are updates from inside transactions visible? |
| Previous Message | Sergey Konoplev | 2008-10-21 14:13:25 | Re: index scan leads to result that is different from sec scan after upgrading to 8.3.4 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-10-21 14:25:50 | Re: automatic parser generation for ecpg |
| Previous Message | Andrew Dunstan | 2008-10-21 14:11:41 | Re: minimal update |