| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Quan Zongliang <quanzongliang(at)yeah(dot)net>, Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Free memory allocated by waitonlock_error_callback() |
| Date: | 2025-10-23 04:29:35 |
| Message-ID: | 1222758.1761193775@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Thu, Oct 23, 2025 at 11:18:09AM +0800, Quan Zongliang wrote:
>> Improve the completeness of the code.
> errfinish() calls MemoryContextReset() on ErrorContext so as any leaks
> like the one you are cleaning up are taken care of. Still, what you
> are suggesting is simple enough and silences a bit valgrind, so agreed
> about the addition of this pfree().
> Let's see if somebody objects to that.
Yeah, I object. Didn't 89d57c1fb already solve this in a more
general way? If it's not fixed by that, why not?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2025-10-23 04:30:21 | Re: Fix lag columns in pg_stat_replication not advancing when replay LSN stalls |
| Previous Message | jian he | 2025-10-23 04:21:34 | Re: [PATCH] pg_get_domain_ddl: DDL reconstruction function for CREATE DOMAIN statement |