Re: [PATCHES] Infrastructure changes for recovery

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: List pgsql-patches <pgsql-patches(at)postgresql(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] Infrastructure changes for recovery
Date: 2008-09-23 15:42:21
Message-ID: 1222184541.4445.400.camel@ebony.2ndQuadrant
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches

On Mon, 2008-09-22 at 23:06 +0100, Simon Riggs wrote:
> On Thu, 2008-09-18 at 10:09 -0400, Tom Lane wrote:
> > Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> > > On Thu, 2008-09-18 at 09:06 -0400, Tom Lane wrote:
> > >> Do we really need a checkpoint there at all?
> >
> > > "Timelines only change at shutdown checkpoints".
> >
> > Hmm. I *think* that that is just a debugging crosscheck rather than a
> > critical property. But yeah, it would take some close investigation,
> > which maybe isn't warranted if you have a less-invasive solution.
> OK, new patch, version 6. Some major differences to previous patch.

> Ready for serious review prior to commit. I will be performing further
> testing also.

Version 7

I've removed the concept of interrupting a restartpoint half way
through, I found a fault there. It was more ugly than the alternative
and less robust. The code now waits at the end of recovery if we are in
the middle of a restartpoint, but forces a do-it-more-quickly also. That
means we won't always get a fast start even though we skip the shutdown
checkpoint, but at least we're sure there's no chance of breakage
because of concurrent activiy, state changes etc..

I'm happy with this now.

Simon Riggs
PostgreSQL Training, Services and Support

Attachment Content-Type Size
recovery_infrastruc.v7.patch text/x-patch 50.0 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2008-09-23 17:36:26 Re: Proposal of SE-PostgreSQL patches (for CommitFest:Sep)
Previous Message Greg Sabino Mullane 2008-09-23 15:34:19 Re: pg_type.h regression?

Browse pgsql-patches by date

  From Date Subject
Next Message Simon Riggs 2008-09-23 21:47:11 Re: Subtransaction commits and Hot Standby
Previous Message Simon Riggs 2008-09-23 13:34:39 Re: hash index improving v3