| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PROPOSAL] Client Log Output Filtering |
| Date: | 2016-04-04 16:36:00 |
| Message-ID: | 12220.1459787760@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Steele <david(at)pgmasters(dot)net> writes:
> On 4/4/16 11:21 AM, Tom Lane wrote:
>> I had in mind a patch that simply added LOG_SERVER_ONLY as another define
>> and did whatever seemed appropriate documentation-wise. I see no reason
>> to touch the places that are currently dealing with client communication
>> failures.
> I still prefer to collapse them into a single value for the current
> implementation.
Right, that's what I had in mind, sorry if I was unclear. I agree that
considering LOG_SERVER_ONLY as the main name and COMMERROR as an alias
is reasonable.
> COMMERROR was not documented in sources.sgml so LOG_SERVER_ONLY wasn't
> either. I'm happy to do that that though it's not clear to me where it
> would go. I could just put it in the general description.
Ah, I thought I remembered that the specific elevels were documented
there, but I see they're only documented in elog.h. Doesn't seem like
it's incumbent on this patch to improve that.
Committed with a quick pgindent fixup.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Verite | 2016-04-04 16:38:32 | Re: raw output from copy |
| Previous Message | Robert Haas | 2016-04-04 16:17:34 | Re: Proposal: "Causal reads" mode for load balancing reads without stale data |