| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: New FSM patch |
| Date: | 2008-09-04 08:54:33 |
| Message-ID: | 1220518473.4371.856.camel@ebony.2ndQuadrant |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 2008-09-04 at 11:07 +0300, Heikki Linnakangas wrote:
> Thanks for the review!
Not as thorough as I would have liked, I must admit.
Thanks for the other confirmations.
> Scenario: The binary tree on a page is corrupt, so that the value of an
> upper node is > Max(leftchild, rightchild).
> Consequence: Searchers will notice the corruption while trying to
> traverse down that path, and throw an elog(WARNING) in search_avail().
> fsm_search will retry the search, and will in worst case go into an
> infinite loop. That's obviously not good. We could automatically fix the
> upper nodes of the tree, but that would wipe evidence that would be
> useful in debugging.
We probably need to break out of infinite loops, especially ones that
output warning messages on each loop. :-)
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2008-09-04 10:10:20 | Re: Window functions patch v04 for the September commit fest |
| Previous Message | Markus Wanner | 2008-09-04 08:53:03 | Re: Conflict resolution in Multimaster replication(Postgres-R) |