Re: small bug in hlCover

From: Sushant Sinha <sushant354(at)gmail(dot)com>
To: Euler Taveira de Oliveira <euler(at)timbira(dot)com>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: small bug in hlCover
Date: 2008-08-04 03:57:11
Message-ID: 1217822231.13402.8.camel@dragflick
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 2008-08-04 at 00:36 -0300, Euler Taveira de Oliveira wrote:
> Sushant Sinha escreveu:
> > I think there is a slight bug in hlCover function in wparser_def.c
> >
> The bug is not in the hlCover. In prsd_headline, if we didn't find a
> suitable bestlen (i.e. >= 0), than it includes up to document length or
> *maxWords* (here is the bug). I'm attaching a small patch that fixes it
> and some comment typos. Please apply it to 8_3_STABLE too.

Well hlCover purpose is to find a cover and for the document '1 2 3 4 5
6 7 8 9 10' and the query '1'::tsquery, a cover exists. So it should
point it out.

On my source I see that prsd_headline marks only min_words which seems
like the right thing to do.

-Sushant.

>
> euler=# select ts_headline('1 2 3 4 5 6 7 8 9 10','1'::tsquery,
> 'MinWords=5');
> ts_headline
> -----------------------------
> <b>1</b> 2 3 4 5 6 7 8 9 10
> (1 registro)
>
> euler=# select ts_headline('1 2 3 4 5 6 7 8 9 10','1'::tsquery);
> ts_headline
> -----------------------------
> <b>1</b> 2 3 4 5 6 7 8 9 10
> (1 registro)
>
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Kirkwood 2008-08-04 05:12:27 Re: Mini improvement: statement_cost_limit
Previous Message Tom Lane 2008-08-04 03:04:12 Re: Instructions for adding new catalog