| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Clean up hba.c of code freeing regexps |
| Date: | 2023-04-13 02:25:42 |
| Message-ID: | 1216962.1681352742@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Thu, Apr 13, 2023 at 12:53:51PM +1200, Thomas Munro wrote:
>> and (2) I missed this when looking for manual memory
>> management code that could be nuked, probably because it's hiding
>> behind a few layers of functions call, but there are clearly comments
>> that are now wrong. So there are two different ways for a commitfest
>> lawyer to argue this should be tidied up for 16.
> Yes, the comments are incorrect anyway.
+1 for cleanup, if this is new code. It does us no good in the long
run for v16 to handle this differently from both earlier and later
versions.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-04-13 02:29:11 | Re: Add ps display while waiting for wal in read_local_xlog_page_guts |
| Previous Message | Tom Lane | 2023-04-13 02:17:47 | Re: [PATCH] Allow Postgres to pick an unused port to listen |