Re: [GENERAL] Fragments in tsearch2 headline

From: Sushant Sinha <sushant354(at)gmail(dot)com>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: Pierre-Yves Strub <pierre(dot)yves(dot)strub(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [GENERAL] Fragments in tsearch2 headline
Date: 2008-07-16 03:54:01
Message-ID: 1216180441.10591.1.camel@dragflick
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

attached are two patches:

1. documentation
2. regression tests
for headline with fragments.

-Sushant.

On Tue, 2008-07-15 at 13:29 +0400, Teodor Sigaev wrote:
> > Attached a new patch that:
> >
> > 1. fixes previous bug
> > 2. better handles the case when cover size is greater than the MaxWords.
>
> Looks good, I'll make some tests with real-world application.
>
> > I have not yet added the regression tests. The regression test suite
> > seemed to be only ensuring that the function works. How many tests
> > should I be adding? Is there any other place that I need to add
> > different test cases for the function?
>
> Just add 3-5 selects to src/test/regress/sql/tsearch.sql with checking basic
> functionality and corner cases like
> - there is no covers in text
> - Cover(s) is too big
> - and so on
>
> Add some words in documentation too, pls.
>
>

Attachment Content-Type Size
headlines_docv0.1.patch text/x-patch 1.7 KB
headlines_regressv0.1.patch text/x-patch 4.5 KB

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Daniel Johnson 2008-07-16 04:04:10 Re: [pgsql-advocacy] Pg booth staffing at OSCON
Previous Message Tom Lane 2008-07-16 03:20:24 Re: 8.3.3 regression test on SCO 5.0.7

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2008-07-16 04:54:47 Re: PATCH: CITEXT 2.0 v3
Previous Message Tom Lane 2008-07-16 03:33:42 Re: Lookup penalty for VARIADIC patch