Re: Explain XML patch v2

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Tom Raney <raneyt(at)cecs(dot)pdx(dot)edu>, pgsql-patches(at)postgresql(dot)org, Gregory Stark <stark(at)enterprisedb(dot)com>
Subject: Re: Explain XML patch v2
Date: 2008-07-05 15:46:29
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches

On Sat, 2008-07-05 at 16:00 +0100, Dave Page wrote:
> On Sat, Jul 5, 2008 at 10:41 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> >
> > It can be optional since plugins can add parameters also.
> GUCs I assume you mean, not grammar. Unless I'm misreading the code
> though, if the plugin is there it will always run instead of the
> regular explain code, so presumabiy that's optional as in XML or
> nothing, not XML or standard output.

You can easily make it switchable between XML and normal.

> > It wouldn't take long to make up a plugin for 8.3 once this patch has
> > been committed to core for 8.4, so if you're saying you'd definitely
> > like it in core then I'm OK with that.
> If i's always there it's definitely more useful to pgAdmin, and
> doesn't require that we instruct users to install more server side
> plugin code to use the features they want.

As I said, I'm OK with that.

Simon Riggs
PostgreSQL Training, Services and Support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen R. van den Berg 2008-07-05 16:34:54 time_stamp type
Previous Message Tom Lane 2008-07-05 15:13:20 Re: PATCH: CITEXT 2.0

Browse pgsql-patches by date

  From Date Subject
Next Message Simon Riggs 2008-07-05 16:17:29 Re: psql command setting
Previous Message Simon Riggs 2008-07-05 15:45:00 Re: pgbench minor fixes