Re: Comment in preptlist.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Comment in preptlist.c
Date: 2023-03-21 14:01:36
Message-ID: 1214495.1679407296@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> writes:
> While working on something else, I noticed $SUBJECT added by commit 86dc90056:
> * For UPDATE and DELETE queries, the targetlist must also contain "junk"
> * tlist entries needed to allow the executor to identify the rows to be
> * updated or deleted; for example, the ctid of a heap row. (The planner
> * adds these; they're not in what we receive from the planner/rewriter.)

> I think that “planner/rewriter” should be parser/rewriter. Attached
> is a patch for that.

Agreed, obviously a thinko :-(

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Regina Obe 2023-03-21 14:29:44 RE: Ability to reference other extensions by schema in extension scripts
Previous Message Brar Piening 2023-03-21 13:57:28 Re: doc: add missing "id" attributes to extension packaging page