Re: Improve correlation names in sanity tests

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improve correlation names in sanity tests
Date: 2022-02-08 19:27:55
Message-ID: 1213263.1644348475@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> I had to do some analysis on the "sanity" tests in the regression test
> suite (opr_sanity, type_sanity) recently, and I found some of the
> queries very confusing. One main stumbling block is that for some
> probably ancient reason many of the older queries are written with
> correlation names p1, p2, etc. independent of the name of the catalog.

I think that was at least partially my fault, and no there isn't
any very good reason for it. Your proposal seems fine.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2022-02-08 19:51:18 Re: decoupling table and index vacuum
Previous Message Chapman Flack 2022-02-08 19:03:21 Re: Documentation about PL transforms