Re: Verified fix for Bug 4137

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Verified fix for Bug 4137
Date: 2008-05-06 23:29:17
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

On Tue, 2008-05-06 at 21:51 +0100, Heikki Linnakangas wrote:

> In fact, what will happen if the checkpoint record's redo pointer points
> to an earlier xlog file:
> 1. The location of the checkpoint record is read by read_backup_label().
> Let's say that it's 0005.
> 2. ReadCheckpointRecord() is called for 0005. The restore command is
> called because that xlog file is not present. The safe truncation point
> is determined to be 0005, as that's what we're reading. Everything
> before that is truncated
> 3. The redo pointer in the checkpoint record points to 0003. That's
> where we should start the recovery. Oops :-(

Yes, this case could be a problem, if the records are in different
files. It's the files that matter, not the records themselves though.

I've extended the patch without introducing another new status variable,
which was my original concern with what you suggested previously.

Simon Riggs

Attachment Content-Type Size
standby_restartbug.v2.patch text/x-patch 3.9 KB

In response to


Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2008-05-06 23:54:29 Re: column level privileges
Previous Message Tom Lane 2008-05-06 22:19:20 Re: [GENERAL] psql \pset pager