| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Introduce group locking to prevent parallel processes from deadl |
| Date: | 2016-02-16 20:15:14 |
| Message-ID: | 12072.1455653714@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> Yeah, you're right. Attached is a draft patch that tries to clean up
> that and a bunch of other things that you raised.
I reviewed this patch. I don't have any particular comment on the changes
in deadlock.c; I haven't studied the code closely enough to know if those
are right. I did think that the commentary elsewhere could be improved
some more, so attached is a delta patch on top of yours that shows what
I suggest.
I've not done anything here about removing lockGroupLeaderIdentifier,
although I will be happy to send a patch for that unless you know of
some reason I missed why it's necessary.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| group-locking-comment-improvements.patch | text/x-diff | 10.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-02-16 20:54:50 | Re: Re: [COMMITTERS] pgsql: Introduce group locking to prevent parallel processes from deadl |
| Previous Message | Tom Lane | 2016-02-16 19:31:36 | Re: Re: [COMMITTERS] pgsql: Introduce group locking to prevent parallel processes from deadl |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2016-02-16 20:19:27 | Re: proposal: PL/Pythonu - function ereport |
| Previous Message | Catalin Iacob | 2016-02-16 20:06:29 | Re: proposal: PL/Pythonu - function ereport |