tuplestore_putvalues()

From: Neil Conway <neilc(at)samurai(dot)com>
To: Patches <pgsql-patches(at)postgresql(dot)org>
Subject: tuplestore_putvalues()
Date: 2008-02-29 00:37:53
Message-ID: 1204245473.22273.7.camel@dell.linuxdev.us.dell.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Attached is a patch that allows an array of Datums + nulls to be
inserted into a tuplestore without first creating a HeapTuple, per
recent suggestion on -hackers. This avoids making an unnecessary copy.
There isn't a really analogous optimization to be applied to tuplesort:
it takes either a TTS, an IndexTuple or a basic Datum, none of which
involve an extra copy.

BTW, I notice that almost all of the callers of the various
tuplestore_put methods switch into the tuplestore's context first. We
could simplify their lives a bit by having the tuplestore remember the
context in which it is allocated and do the switch itself. Perhaps it's
not worth bothering with at this point, though.

-Neil

Attachment Content-Type Size
tuplestore_putvalues-1.patch text/x-patch 12.2 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2008-02-29 02:50:35 Re: SRF memory leaks
Previous Message Robert Lor 2008-02-28 23:52:27 Re: DTrace probe patch for OS X Leopard