Re: pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY
Date: 2008-01-15 21:02:42
Message-ID: 1200430962.4266.1792.camel@ebony.site
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Mon, 2008-01-14 at 18:46 +0000, Tom Lane wrote:
> Log Message:
> -----------
> Fix an ancient oversight in libpq's handling of V3-protocol COPY OUT mode:
> we need to be able to swallow NOTICE messages, and potentially also
> ParameterStatus messages (although the latter would be a bit weird),
> without exiting COPY OUT state. Fix it, and adjust the protocol documentation
> to emphasize the need for this. Per off-list report from Alexander Galler.

My reading of this is that previously a PQgetCopyData() operation would
fail mysteriously because of

i) a reload of postgresql.conf, following the setting of any of the
following parameters client_encoding, DateStyle, TimeZone, and
standard_conforming_strings.

ii) any previous LISTEN command on the session running the COPY

Would that be correct? Did I miss anything?

--
Simon Riggs
2ndQuadrant http://www.2ndQuadrant.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2008-01-15 21:20:28 pgsql: Prevent CLUSTER from decreasing a relation's relfrozenxid.
Previous Message Tom Lane 2008-01-15 18:57:00 pgsql: Revise memory management for libxml calls.

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2008-01-15 21:22:45 Re: pgsql: Fix an ancient oversight in libpq's handling of V3-protocol COPY
Previous Message Greg Smith 2008-01-15 20:14:56 Re: SSL over Unix-domain sockets