Re: Partitioning documentation example

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-documentation <pgsql-docs(at)postgresql(dot)org>
Subject: Re: Partitioning documentation example
Date: 2008-01-04 16:15:50
Message-ID: 1199463350.18598.121.camel@ebony.site
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On Fri, 2008-01-04 at 10:27 -0500, Bruce Momjian wrote:

> It seems to me it would be much clearer if we added a second example
> that used to_char() to create the INSERT statement dynamically based on
> NEW.logdate:
>
> CREATE OR REPLACE FUNCTION measurement_insert_trigger()
> RETURNS TRIGGER AS $$
> BEGIN
> EXECUTE 'INSERT INTO measurement_y' || to_char(NEW.logdate,'YYYY_mMM') || ' VALUES (NEW.*)';
> END;
> $$
> LANGUAGE plpgsql;
>
> It will of course fail if the table does not exist, which I think is
> what we want. This trigger function would not have to be modified when
> new tables are added.

I like your new trigger better than the old, but I am still
uncomfortable with recommending we use triggers with COPY for
performance reasons and we should add a caveat.

--
Simon Riggs
2ndQuadrant http://www.2ndQuadrant.com

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Bruce Momjian 2008-01-04 16:54:48 Re: Partitioning documentation example
Previous Message Bruce Momjian 2008-01-04 15:27:07 Partitioning documentation example