Re: Schema-qualify function calls in information_schema

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Fetter <david(at)fetter(dot)org>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Schema-qualify function calls in information_schema
Date: 2017-12-20 17:34:31
Message-ID: 11960.1513791271@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Fetter <david(at)fetter(dot)org> writes:
> Please find attached a patch against master to do $Subject, which
> tones down the hilarity, at least in information_schema.

The views do not need this sort of change, because they're parsed
only once during initdb.

The bodies of functions in information_schema do need qualification,
but I think they've already got it, or at least I remember having
looked through them for the issue in the past.

> Another way to fix this, which I know will be controversial, is simply
> to mandate that pg_catalog (and possibly information_schema) be
> non-changeably first in the search_path.

I think that ship sailed long ago. It might be workable to attach
"SET search_path" clauses to the functions, if you want to make them
more bulletproof.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2017-12-20 17:35:01 Re: Cost Model
Previous Message neto brpr 2017-12-20 17:29:37 Cost Model