From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Erik Wienhold <ewie(at)ewie(dot)name> |
Cc: | Greg Sabino Mullane <htamfids(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: psql: Count all table footer lines in pager setup |
Date: | 2025-10-02 21:00:30 |
Message-ID: | 1195878.1759438830@sss.pgh.pa.us |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Erik Wienhold <ewie(at)ewie(dot)name> writes:
> On 2025-10-02 00:25 +0200, Tom Lane wrote:
>> I am not entirely sure that we should commit 0002 though; it may be
>> that the savings is down in the noise anyway once you consider all the
>> other work that happens while printing a big table. A positive reason
>> not to take it is something I realized while checking test coverage:
>> we never execute any of the maybe-use-the-pager branch of PageOutput
>> in the regression tests, because isatty(stdout) will always fail.
I realized that we could address that if we really wanted to,
using the same infrastructure as for tab-completion testing.
0001 and 0002 attached are the same as before, and then I added
0003 which adds a draft-quality TAP test. Code coverage checks
show that this adds only about 10 more lines of coverage in
psql proper, but in print.c most of the pager-related logic is
now covered.
regards, tom lane
Attachment | Content-Type | Size |
---|---|---|
v4-0001-Improve-psql-s-ability-to-select-pager-mode-accur.patch | text/x-diff | 9.3 KB |
v4-0002-Make-some-minor-performance-improvements-in-psql-.patch | text/x-diff | 7.2 KB |
v4-0003-Add-a-TAP-test-to-exercise-psql-s-use-of-PAGER.patch | text/x-diff | 4.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2025-10-02 21:00:54 | Re: [PATCH] Add tests for Bitmapset |
Previous Message | Nathan Bossart | 2025-10-02 20:42:43 | Re: disallow big-endian on aarch64 |