| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Gregory Stark <stark(at)enterprisedb(dot)com> |
| Cc: | PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: xlogdump |
| Date: | 2007-11-04 09:13:25 |
| Message-ID: | 1194167605.4258.33.camel@ebony.site |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 2007-11-02 at 10:54 +0000, Gregory Stark wrote:
> Incidentally I would like to call xlog.c:RecordIsValid() which is currently a
> static function. Any objection to exporting it? It doesn't depend on any
> external xlog.c state.
You'll have some fun with that because most of the stuff in xlog.c
depends upon module-level state.
We should change that, but I'd like to see Florian's code go in first
then refactor things.
If you change those programs too much we'll need completely separate
programs for each release, which might be a bad thing.
--
Simon Riggs
2ndQuadrant http://www.2ndQuadrant.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2007-11-04 09:22:25 | Re: Proposal: Select ... AS OF Savepoint |
| Previous Message | Simon Riggs | 2007-11-04 09:05:27 | Re: Asynchronous commit documentation gap |